Compare commits

...
Author SHA1 Message Date
Brandon ThomasandClaude Opus 5.5 6b04c4d6e0 Fix two ui-egui tests broken on main by concurrent landings
- profile_open_tests: #5614 renamed the built-in profile to "(PhotoCraft)" after #5208
  hard-coded "(Photocraft)" in the Use-embedded button label.
- smart_object_curves_preview_keeps_its_size_on_a_reduced_proxy (#5779): the reduced
  square is in the right place, but its corner pixels are 220/255 after the smart
  object's resampling; assert full coverage inside and over half at the corners.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-14 23:18:27 -04:00
2 changed files with 6 additions and 2 deletions

No files matched your search

+5 -1
View File
@@ -1920,9 +1920,13 @@ mod tests {
assert_eq!(sm.smart_filters.len(), 1, "the preview adds the Curves smart filter");
assert_eq!(shown.size, crate::proxy::proxy_document(&doc, k).size);
// The 16 px square at (16, 16) is a 4 px square at (4, 4) on the proxy, not 16 px at (16, 16).
for (x, y) in [(4, 4), (5, 6), (7, 7)] {
// Its corners are partly covered by the smart object's resampling (220/255), its inside fully.
for (x, y) in [(5, 5), (5, 6), (6, 6)] {
assert!(alpha(&shown, x, y) > 0.99, "({x}, {y}) is inside the reduced square");
}
for (x, y) in [(4, 4), (7, 7)] {
assert!(alpha(&shown, x, y) > 0.5, "({x}, {y}) is a corner of the reduced square");
}
for (x, y) in [(2, 2), (9, 9), (12, 12), (15, 15)] {
assert!(alpha(&shown, x, y) < 0.01, "({x}, {y}) is outside the reduced square");
}
+1 -1
View File
@@ -13,7 +13,7 @@ use photocraft_doc::{Color, ColorMode, Document, SampleType, Size};
use photocraft_engine::Session;
use serde_json::Value;
const USE: &str = "Use the embedded profile (Adobe RGB (1998)-compatible (Photocraft))";
const USE: &str = "Use the embedded profile (Adobe RGB (1998)-compatible (PhotoCraft))";
const CONVERT: &str = "Convert to the working space (sRGB IEC61966-2.1)";
const DISCARD: &str = "Discard the embedded profile (don't color manage)";