mirror of
https://github.com/storytold/pdfcraft.git
synced 2026-10-14 19:27:04 -04:00
Follows the owner's AGENTS.md §4 / CLAUDE.md rules with what the shared standard (craftrules/standards/never-crash.md) adds: why (lost work) and that it outranks feature work, the `unsafe` ban (workspace `unsafe_code = "forbid"`; no unsafe exists outside vendor/), the last-resort guard around commands and file import/export, the clippy ratchet attribute, and a root clippy.toml that lets tests use unwrap/expect/panic/indexing. Co-Authored-By: Claude Opus 5.5 <[email protected]>
5.2 KiB
5.2 KiB
PrintCraft — instructions for agents
PrintCraft is a clean-room, open-source, Rust-native PDF application targeting Adobe Acrobat Pro parity. It runs natively on macOS, Windows and Linux, and on the web via WASM. It is the sibling of ../photocraft (a Photoshop-class editor) and follows the same conventions.
Start every session here
- Read
plan/STATUS.md: the current milestone, the next unchecked task and any blockers.ROADMAP.mdholds the milestone estimates and progress; update its table and log at the end of every session. - Read that task in
plan/execution-plan.md§3, the relevant section ofplan/architecture.md, and the README of the crate you're touching. - Follow the autonomous operation protocol in
plan/execution-plan.md§7 (orient → plan → implement + test → verify → record → commit). Don't stop to ask unless §7 lists the decision as the user's.
plan/ is gitignored (local-only, like PhotoCraft). The machine-readable parity checklist lives in parity/ (committed).
Non-negotiables
- Assets: read
AGENTS.md§1 before adding or showing any icon, image, font or document. No assets from Adobe products, ever. Only openly licensed or contributor-original assets are allowed, each with an entry inATTRIBUTION.toml.cargo xtask assetsenforces this.AGENTS.mdoverrides this file. - Clean-room.
- Never read, disassemble or copy anything inside the Acrobat bundle (names and listings only). Never open
Contents/Resources/JavaScripts/. - Behaviour comes from public docs, specs (ISO 32000-2, the Arlington model) and black-box observation (
plan/acrobat/). - Never copy GPL/AGPL code. MuPDF, Ghostscript, Poppler, veraPDF and DSS run only as external oracle processes.
- See
plan/README.md§Clean-room andplan/adr/0001.
- Never read, disassemble or copy anything inside the Acrobat bundle (names and listings only). Never open
- Privacy. When observing Acrobat, use synthetic fixtures only. Never capture the Home view, recent files or account info. Capture by window id (
plan/acrobat/tools/). Never commit Acrobat outputs, corpus files or personal data. - Layering. Nothing below L7 depends on egui/winit/eframe/rfd (
plan/architecture.md§3).cos/filters/crypt/arlingtonstay standalone. - Fidelity. The PDF object graph is the model. Preserve unknown data. Saves are incremental unless a full rewrite is required. Never silently drop or repair data without recording it.
- Never panic. Every PDF, script, MCP call, settings file and keystroke is untrusted input, and none of it may crash the app or lose the user's work. This outranks feature work. Return
Result(the crate's error enum) and propagate with?, or fall back leniently and record it. In non-test code:- No
unwrap/expect/panic!/unreachable!/todo!unless it is provably infallible, with a comment saying why. - No indexing or slicing with input-derived positions (use
get, and slice strings only at char boundaries). - Use checked or saturating arithmetic on input-derived numbers, and guard against division by zero and NaN/inf casts.
- Cap allocations sized by input, and bound recursion with depth limits or seen-sets.
- Handle lock poisoning.
- No
unsafe(unsafe_code = "forbid"). - Every crash fix gets a synthetic regression test. See
AGENTS.md§4 andcraftrules/standards/never-crash.md.
- No
- Rust only in the product and build (
xtask). No handwritten JS/TS. - Quality gates before every commit:
cargo fmt --check,cargo clippy --workspace -- -D warnings,cargo test --workspace, and the wasm check oncextask ciexists (M0). - Commits: one task id per commit (e.g.
M1.4: xref stream reader). Commit only green states. End messages with the attribution line required by the environment.
Running and looking at the app
cargo run -p printcraft -- <file.pdf>opens the desktop app.cargo run -p printcraft-cli -- run --script steps.json --root DIRdrives the engine headlessly through the automation tools (printcraft-cli toolslists them). Use it, together withpage_render, to check engine changes.printcraft-cli mcpis the opt-in MCP server (AGENTS.md §3).cargo xtask fuzz --time 300mutation-fuzzes open/render/edit/save in child processes. Findings land infuzz-out/findings/(git-ignored; never commit corpus-derived files). Turn every real finding into a small synthetic regression test before fixing it.cargo xtask parity [--partial]reports Acrobat-parity progress fromparity/acrobat-features.toml. Update the entry when a feature ships.cargo xtask demo-pdfbuildsdist/demo/printcraft-showcase.pdf(needs Chrome) for visual checks.- For UI work, look at the result. Either launch
printcraft --control FILE doc.pdfand useprintcraft-cli ui --control FILE screenshot --out x.png(plusinspect,click,key,type,command,set), or take a headless shot withcargo run -p printcraft-ui-egui --example shot. Compare againstplan/acrobat/02-ui-ux.md. Control-channel tests use kittest (crates/ui-egui/tests/control.rs). - Parallel agents: use a separate
CARGO_TARGET_DIRper agent and separate git worktrees.
Current bootstrap debt (tracked in STATUS.md)
printcraft-renderrenders through thehayrocrate directly and inspects documents throughlopdf. Both get replaced bycos/model/ the DisplayList device (M1–M2, ADR-0004).