Vendored crates
Permissively licensed crates we carry small patches for. Each directory keeps the upstream
licence files unchanged. Every patch is marked PdfCraft patch: in the source, is covered by a
PdfCraft test, and should be proposed upstream. Remove the vendored copy once upstream releases
the fix. Vendoring copyleft code is never allowed (plan/adr/0001).
The four patched Hayro crates are supplied by the shared craft-pdf dependency.
Their source and patch ledger live at the immutable revision recorded in Cargo.lock;
see the PDF backend integration. Local application patches
below continue independently.
| Crate | Version | Licence | Patches | Test |
|---|
| lopdf | 0.45.0 | MIT | (1) PNG predictor rows longer than the data are refused before their buffers are allocated (a fuzzed /Columns 4294967295 allocated two 4 GiB rows), and empty frames return without row buffers; (2) predictor row widths use saturating arithmetic or reject overflow; (3) sub-byte TIFF Predictor 2 scratch is bounded by the samples present in the input instead of the declared /Colors, aligned with lopdf#589 | (1) inspect::tests::png_predictor_rows_longer_than_the_data_are_refused_before_allocating, inspect::tests::empty_png_predictor_frames_do_not_allocate_rows; (2) inspect::tests::tiff_subbyte_predictor_row_width_overflow_is_refused; (3) inspect::tests::tiff_subbyte_predictor_scratch_is_bounded_by_available_samples, inspect::tests::tiff_subbyte_predictors_keep_components_rows_and_padding |
| lopdf | 0.45.0 | MIT | (1) PNG predictor rows longer than the data are refused before their buffers are allocated (a fuzzed /Columns 4294967295 allocated two 4 GiB rows), and empty frames return without row buffers; (2) predictor row widths use saturating arithmetic or reject overflow; (3) sub-byte TIFF Predictor 2 scratch is bounded by the samples present in the input instead of the declared /Colors, aligned with lopdf#589; (4) the object lookup keeps its cycle history through compressed objects, requires an ordinary in-file container, and caps the chain of indirect lookups at 16 (a chain of new objects, each a /Length compressed in a container whose own /Length names the next, or a stream whose /Length names the next stream, overflowed the stack: a dev build's 2 MiB thread within 800 hops); (5) object-stream members are parsed within their own extent (up to the next distinct offset), an entry whose offset repeats an earlier entry's is skipped (so a repeated object number can resolve to its earlier entry), and offsets are processed in index order | (1) inspect::tests::png_predictor_rows_longer_than_the_data_are_refused_before_allocating, inspect::tests::empty_png_predictor_frames_do_not_allocate_rows; (2) inspect::tests::tiff_subbyte_predictor_row_width_overflow_is_refused; (3) inspect::tests::tiff_subbyte_predictor_scratch_is_bounded_by_available_samples, inspect::tests::tiff_subbyte_predictors_keep_components_rows_and_padding; (4) inspect::tests::compressed_object_self_container_does_not_recurse, inspect::tests::compressed_object_mutual_containers_do_not_recurse, inspect::tests::object_stream_length_cycle_does_not_recurse, inspect::tests::compressed_object_container_chain_does_not_recurse, inspect::tests::compressed_length_chain_does_not_recurse, inspect::tests::plain_stream_length_chain_does_not_recurse, inspect::tests::compressed_objects_and_indirect_stream_length_still_load, inspect::tests::compressed_length_in_a_container_with_an_indirect_length_still_loads; (5) inspect::tests::object_stream_member_extents_bound_owned_strings, inspect::tests::object_stream_member_extents_preserve_index_order_and_whitespace |
| lopdf | 0.45.0 | MIT | (1) PNG predictor rows longer than the data are refused before their buffers are allocated (a fuzzed /Columns 4294967295 allocated two 4 GiB rows), and empty frames return without row buffers; (2) predictor row widths use saturating arithmetic or reject overflow; (3) sub-byte TIFF Predictor 2 scratch is bounded by the samples present in the input instead of the declared /Colors, aligned with lopdf#589 | (1) inspect::tests::png_predictor_rows_longer_than_the_data_are_refused_before_allocating, inspect::tests::empty_png_predictor_frames_do_not_allocate_rows; (2) inspect::tests::tiff_subbyte_predictor_row_width_overflow_is_refused; (3) inspect::tests::tiff_subbyte_predictor_scratch_is_bounded_by_available_samples, inspect::tests::tiff_subbyte_predictors_keep_components_rows_and_padding |
| winit | 0.30.13 | Apache-2.0 | (1) on Windows 11 (build 22000 and later), WM_DPICHANGED applies the rect Windows suggests. It used to nudge the window onto the monitor MonitorFromWindow names, which during a drag is still the monitor being left; the nudge sent another WM_DPICHANGED, so a window dragged to a monitor with another scale factor grew and stayed on the wrong monitor at the wrong scale (#324). Backport of winit master 488c036a (winit#4341), which no 0.30 release has; Windows 10 keeps the old adjustment, as on winit master. (2) on Wayland, a seat's text input is destroyed when the seat goes away, not whenever it loses a capability: losing any capability (a touch screen or tablet unplugged, a remote-desktop session ending) destroyed it, and only an added capability recreated it, so IME stopped working until restart. Port of winit#4747; (3) on Windows, an IME composition reports its cursor from GCS_CURSORPOS only when WM_IME_COMPOSITION says it is set, and at the end of the composition otherwise: the Microsoft Korean IME never sets it, so the cursor read as 0 (egui then drew no caret while composing; it now draws it after the syllable). Port of winit#4746; (4) on Windows, a hidden window is not maximized until it is shown, and a hidden window shown while maximized gets one ShowWindow(SW_MAXIMIZE): SW_MAXIMIZE shows a hidden window, so PdfCraft, which eframe keeps hidden until its first frame is drawn, appeared unpainted (white) when it restored a maximized window, and could lose its focus. Port of winit#4587 (the later, focus-safe form of winit#4575); (5) on X11, when allowing or disallowing IME replaces the focused window's input context (egui does it each time a text field gains or loses focus), the new context is focused: no focus event follows, so it stayed unfocused until the window lost and regained focus. Port of winit#4727; (6) on macOS, insertText commits through IME when a composition was started (pending_commit, set by setMarkedText) rather than when marked text is left: input methods that end a composition with unmarkText before insertText lost the text, and Apple Korean dropped the key typed after a syllable (한 then 5 or ;); other insertText calls stay KeyboardInput; a commit outside a key press (a candidate clicked with the mouse, dictation) clears the marked text and leaves no key to swallow, as in winit#4748 (without it the next key, such as Backspace, was lost). validAttributesForMarkedText lists the underline and marked-clause attributes, without which some input methods don't compose. Port of winit#4650, the 0.30 backport of winit#4651 (merged on winit master), with the underline attribute spelled as AppKit's NSUnderlineStyleAttributeName (NSUnderline); (7) on macOS, disallowing IME with a composition in progress (focus leaving a text field) tells the input method to discard its marked text (discardMarkedText): it kept composing it once IME was allowed again, so the abandoned syllable came back (하, then 가 typed in the next field, became 학, then 하 + 가; Japanese か then さ became 傘). Port of winit#4745; (8) on macOS, text inserted outside a key press without a composition (the emoji picker) is reported as Ime::Commit; it was dropped. Port of the emoji-picker part of winit#4749 (0.30 backport of winit#4748); its selectedRange change for dictation is left out because it switches on press-and-hold for every held key (an accent menu instead of key repeat, and the chosen accent added after the repeated letters); (9) on macOS, a key whose text was committed through IME isn't also sent as KeyboardInput unless AppKit forwards it as a command (Enter): Apple Korean answers Space with no syllable in progress with setMarkedText(" "), insertText(" "), setMarkedText(""), and the last call reset winit's state, so the space arrived twice. Same goal as winit#4478, whose changes don't reach this call order (macOS 14); to be proposed upstream there; (10) on macOS, when the first key in a fresh app reaches Apple Korean's insertText as a raw compatibility jamo instead of starting a composition, that key is interpreted once more, synchronously, before it is sent as KeyboardInput (g k s typed ㅎㅏㄴ instead of 한); only an unmodified, non-repeated first key whose one callback inserts that same jamo, with IME enabled and nothing composed, focus and input source unchanged, is retried (ime_startup.rs). Port of winit#4744, with its policy tests.; (11) on X11 without Xft.dpi, the scale factor comes from the X screen's configured DPI (its size in pixels and millimetres) before the output's physical density from RandR: Xorg can deliberately run a dense panel at 96 DPI, and only winit applications then looked zoomed; Xft.dpi still wins, WINIT_X11_SCALE_FACTOR still overrides, and a screen reporting no size keeps the RandR fallback. PdfCraft patch (#1150, replacing the launcher pin proposed in #908). The published crate's asset files (docs/res/*.svg, examples/data/*.png) are left out, so its window example doesn't build | (1) pdfcraft tests::winit_carries_the_windows_11_monitor_scale_fix keeps the patch in the build; the drag itself needs two monitors with different scale factors on Windows 11; (2) pdfcraft tests/winit_wayland_text_input.rs; the capability change itself needs a Wayland session and an input method; (3) pdfcraft tests/winit_windows_ime_cursor.rs; composing itself needs the Microsoft Korean IME; (4) pdfcraft tests/winit_windows_hidden_maximized.rs; the start-up itself needs Windows and a window that was closed maximized; (5) pdfcraft tests/winit_x11_ime_focus.rs; switching fields itself needs an X11 session and an input method (IBus, fcitx5); (6) pdfcraft tests/winit_macos_ime_commit.rs; composing itself needs macOS and an input method; (7) pdfcraft tests/winit_macos_ime_discard.rs; composing itself needs macOS and an input method; (8) pdfcraft tests/winit_macos_emoji_picker.rs; the picker itself needs macOS; (9) pdfcraft tests/winit_macos_korean_space.rs; composing itself needs macOS and Apple Korean; (10) pdfcraft tests/winit_macos_korean_first_key.rs and ime_startup.rs's own tests (run them with rustc --test); typing itself needs macOS and Apple Korean; (11) pdfcraft tests/winit_x11_dpi.rs keeps the patch in the build, and util::randr tests the policy (run them in the vendored crate); the scale itself needs an X11 session |
| egui-wgpu | 0.36.2 | MIT OR Apache-2.0 | (1) winit::surface_fit: a window's surface is configured within the device's max_texture_dimension_2d, both sides shrunk by one factor that egui then draws at (pixels_per_point × render_scale), so the whole window is drawn into the surface (on DX12 it is stretched over the window and lines up with the pointer; wgpu's GL backend copies it unscaled into a corner); the longer side becomes exactly the limit; the depth and MSAA textures follow, and a recreated surface starts again from the window's own size. egui-wgpu configured the window's size as is, and Surface::configure panics beyond the limit: a window restored at another monitor's scale (opening an Outlook attachment on a mixed-DPI laptop asked an 8192-pixel device for 8600 × 3423, #577) or stretched across monitors closed PdfCraft, before its window appeared when it happened at start-up (emilk/egui#8361). The published crate leaves out egui's licence files; LICENSE-APACHE and LICENSE-MIT are from the 0.36.2 tag; (2) winit::catch_errors: a new window's surface is configured inside wgpu error scopes (validation, out of memory, internal), and a failure is returned as WgpuError::ConfigureSurface (for the root window at start-up eframe returns it as Error::Wgpu, which PdfCraft retries with OpenGL); nothing is kept for the window. wgpu's default handler panicked instead, and eframe configures the root surface before the app is created, so a driver that can't configure one closed PdfCraft at launch (a 2015 Intel GPU through wgpu's GL backend timed out waiting for the GPU to go idle, GpuWaitTimeout, #519). Unchanged, so still a panic: an error in a later reconfigure (resize, a lost surface), a device lost during the first configure (wgpu reports it only to a callback), and a window shown at zero size (first configured on resize) | (1) pdfcraft tests::a_window_larger_than_the_gpu_limit_gets_a_surface_within_it, tests::surface_fit_never_empties_or_overflows_a_surface, and tests::egui_wgpu_carries_the_surface_size_fit, which keeps the patch in the build and in the paths that size a surface; (2) pdfcraft tests::a_gpu_error_while_a_window_is_set_up_is_returned_not_a_panic (a real device: an error inside catch_errors is returned, not a panic) and tests::egui_wgpu_returns_a_surface_it_cannot_configure_as_an_error, which keeps it around add_surface's configure |
Renderer startup errors: egui-wgpu::RenderState::create also wraps Renderer::new in
winit::catch_errors when the winit feature is enabled. A rejected shader or render pipeline
is returned as WgpuError::CreateRenderer, allowing PdfCraft's existing startup OpenGL retry.
The regression pdfcraft tests::pipeline_creation_error_is_returned_and_device_remains_usable
uses an invalid three-sample pipeline, then valid and invalid pipelines again on the same device.
Later rendering errors, device loss, and non-winit renderer construction are unchanged.
Temporary: hayro is the bootstrap renderer and lopdf the bootstrap inspector (ADR-0004); M2.6 replaces them with our own devices and cos/model.
TIFF predictor decoding: hayro-syntax aligns the output writer to a byte boundary after each
row before splitting off its buffer. Packed RGB samples at 1, 2 or 4 bits per component can
leave padding bits; without alignment later rows overwrite the preceding row or decode empty.
Covered by raster::tests::tiff_predictor_packed_rgb_rows_keep_their_byte_boundaries (including
horizontal differencing and an 8-bit control) and
raster::tests::tiff_predictor_packed_rgb_image_renders_every_row.
Text extraction: hayro-interpret exposes OutlineGlyph::is_vertical from a Type0 font’s CMap writing mode. PdfCraft follows negative glyph-space y for WMode 1 so upright vertical columns can be searched (#126).
Lab Bradford follow-up to #1237: Lab adapts XYZ to D65 with white-point ratios
computed in Bradford LMS coordinates. CalRGB's existing flat-white and
black-point normalization is unchanged. lab_bradford_tests checks independent
D50/equal-energy neutral and chromatic oracles, D65 identity, and direct/Indexed
consistency (including an asymmetric chromatic Range), and zero/overflowing
cone-response fallback.