Preserve source fonts in text editing and resize clipped artwork (#1116)

* M0: remove upstream trademark artwork from contributor fork Use the existing document icon and a plain project label. Remove trademark asset entries and regenerate attribution as required for modified forks. Co-authored-by: OpenAI Codex <[email protected]> * M7: group compatible PDF words and hide source text during editing Join compatible words across text objects and subset-font spaces, recognize component colours, and reuse subset fonts with numeric space positioning. Render a read-only background with the selected glyphs removed while the inline editor is open. Keep one frame and source line breaks, and reset the layout width when switching paragraphs. Expose the same preview through page_render. Add synthetic extraction, save/reopen, preview and UI regressions. Record the remaining mixed-style paragraph and installed-font limitations. Co-authored-by: OpenAI Codex <[email protected]> * M7: preserve rich PDF regions and preview text edits in place Group mixed source runs into complete visual regions, retain run styles and source encodings, and use validated embedded source faces in the inline editor. Preserve source baselines and show a single live frame as text grows or shrinks, backed by a read-only draft geometry tool. Validation: strict workspace Clippy, workspace tests, all 30 WASM crates, asset and parity gates, licensed synthetic edit/save/reopen and desktop checks, and an opt-in four-page private-document regression. Co-authored-by: OpenAI Codex <[email protected]> * M7: keep cropped artwork from blocking text editing Track page/path clipping separately from full image placement, use visible selection bounds, and prioritize text hit testing over overlapping artwork. Preserve fixed clips during image transformations and expose visible bounds through the headless tools. Validation: strict workspace Clippy, workspace tests, 30 WASM crates, asset/parity gates, synthetic engine/tool/UI and native desktop checks, both private-document UI regressions, and all-page local edit/save/reopen/undo on a four-page cropped-artwork PDF. Co-authored-by: OpenAI Codex <[email protected]> * M7: resize cropped images with their clipping paths Keep the visible frame and image pixels under the same transform. Preserve the opposite corner and respond to diagonal, horizontal-only and vertical-only corner drags without jumping from an off-centre grip. Refuse shared clipping scopes that would move unrelated content. Add synthetic engine/tool/UI regressions and opt-in private-file coverage for 80 corner gestures and 10 grow/shrink save/reopen/undo render checks. Co-authored-by: OpenAI Codex <[email protected]> * M7: complete source font subsets and preserve clipped editing Add explicit document fonts, CFF embedding, range formatting and bounded contextual shaping; isolate shared image clips and verify private Chinese edits on all pages. Co-authored-by: OpenAI Codex <[email protected]> * Revert "M0: remove upstream trademark artwork from contributor fork" This reverts commit 3aa539b5b6. * Test: give the text layer up to 4 s before copying (it flaked on a loaded machine) --------- Co-authored-by: Kamoliddin Fatkhullaev <[email protected]> Co-authored-by: OpenAI Codex <[email protected]> Co-authored-by: Brandon Thomas <[email protected]> Co-authored-by: Claude Opus 5.5 <[email protected]>
2026-10-14 19:27:04 -04:00 · 2026-10-11 20:27:55 -04:00
1 parent f3571c591f
commit 6d843a8e8b
@@ -0,0 +1,51 @@
+# Editing existing text and source subsets
+
+Click a text region in **Edit a PDF → Edit text and images**. One editor contains its
+source rows and mixed styles. Embedded TrueType and OpenType/CFF faces are used in memory;
+source font programs, colour, size and baseline anchors stay intact. A textless preview
+prevents a second copy underneath. The frame shows the live extent as text grows or shrinks.
+
+A subset font contains only some of the original face's glyphs. A new character cannot be
+reconstructed from a glyph the PDF does not contain. **Load font…** imports an openly licensed,
+embeddable standalone `.ttf` or `.otf` face. **Installed fonts…** discovers eligible user-installed
+faces on request, off the UI thread; the document-font menu selects resources already on the
+page. Select **Keep source fonts** to preserve each run's original face. A matching full face
+completes its subsets automatically, including new Chinese characters. Choosing another face
+is explicit. Fonts with restricted embedding, unsupported collections, excluded families or
+no open-licence declaration are refused. Interface fallback fonts are never exported.
+
+The full selected program, glyph mappings, widths and Unicode text are embedded in the PDF.
+Saving and reopening therefore needs no locally installed font. Original subset bytes are
+preserved. Optional matching faces from `CRAFT_FONTS_DIR` can also complete source subsets;
+this works only when that build input actually contains the full face. This change does not
+add a font binary or change the release font pin. Fonts shared by releases belong in
+`storytold/craft-fonts` under the repository's asset rules.
+
+Select text within the editor before changing size, colour, font, underline or spacing to
+format that selection. Automation supports up to 1024 disjoint UTF-8 byte ranges with the
+same properties; invalid or overlapping ranges fail atomically. Untouched source formatting
+survives. OpenType shaping uses the selected/source face's substitution and positioning
+rules, preserves marks and ligatures, and applies Unicode bidi ordering for a single face.
+Logical text remains available after save/reopen through ToUnicode and ActualText.
+
+For headless editing, use `text_font_files` → `text_font_import` → `text_fonts` and pass a
+resource to `text_edit.font_resource`. `text_edit.ranges` holds selected range formatting.
+`text_edit_layout` accepts resource/ranges too and measures a draft without applying it.
+All file inputs respect CLI root confinement; importing a font and applying text are undoable.
+
+Explicit marked paragraph/heading scopes prevent unrelated tagged regions from merging.
+Compatible geometry groups untagged content, including runs split across content streams
+or equivalent graphics transforms. Geometry cannot infer author intent in every untagged
+PDF. Semantic structure-tree preservation, legacy Type 1/Type 3 inline font preview,
+font collections/variable-font instances, mixed-font/style contextual runs and complete rotated
+layout fidelity still need broader coverage. Do not interpret the passing real-file checks
+as a guarantee for every PDF.
+
+Private acceptance tests are opt-in and keep inputs unmodified. They exercise actual Chinese
+keyboard insertion/deletion on all four pages, source-face/baseline checks and identical
+in-memory renders before and after saving/reopening. Synthetic tests cover full TrueType
+mapping, OpenType/CFF, Arabic marks/ligatures/mixed bidi, repeated edits, disjoint styles,
+invalid ranges, font selection and root confinement. CLI acceptance repeats insertion/deletion
+and two saves/reopens on four pages; independent PDFium checks extraction and rendering.
+No private document, font or screenshot
+is included in the repository.
@@ -23,3 +23,20 @@ Forms have `pixels: [0, 0]`, since they have no single bitmap resolution. Use th
 number with `image_edit` (move, rotate, flip_horizontal, flip_vertical, delete).
 Coordinates are top-left-origin page points. `image_save` and `image_edit`'s replace action
 return a clear error for Form artwork.
+
+Selection frames follow the visible portion of artwork after page and path clipping. Clicking
+editable text takes precedence over overlapping artwork, including labels inside an image's
+visible rectangle. Hidden image placements have no selection frame. Bezier extrema determine
+curved-path frames. Hit testing evaluates the actual clipping paths with their nonzero or
+even-odd fill rule, so holes and empty corners do not intercept clicks. Intersections of several
+curved clips can still have a loose bounding frame. Dragging the visible frame moves or resizes
+the full placement by the same change; resizing keeps the opposite corner fixed, including
+horizontal-only or vertical-only corner drags, and grabbing a grip slightly off-centre does not
+jump. A selected corner keeps control of its drag even over a text label; the drag previews one
+frame and applies one undoable edit on release. A clip that belongs to the image alone
+(`q re W n cm Do Q`) moves with it; a clip shared with other content stays where it is.
+
+`image_hit` applies the same path and hole checks headlessly. `page_images` retains `rect` as
+the full placement rectangle used by `image_edit` and adds `visible_rect` for selection (null
+when fully clipped). `object_list` reports visible artwork bounds while keeping the original
+source indexes. A selection frame does not create, remove or enlarge the PDF's clipping path.
@@ -1,7 +1,6 @@
 # Where PdfCraft falls short of Acrobat Pro

-> **Last reviewed:** 2026-10-10 · **Last updated:** 2026-10-11 · **Change:** patch (gap 2: hayro patch counts after the native-gradient backport) · **Target:** Adobe Acrobat Pro (Acrobat DC, continuous track 26.002.21931, macOS)
-> **Last reviewed:** 2026-10-10 · **Last updated:** 2026-10-11 · **Change:** minor (gap 1 closed by #836; fixed issues removed from gaps 3, 6 and 16) · **Target:** Adobe Acrobat Pro (Acrobat DC, continuous track 26.002.21931, macOS)
+> **Last reviewed:** 2026-10-10 · **Last updated:** 2026-10-11 · **Change:** minor (document-font subset completion and curved/shared image clips in the contributor fork; gap 2: hayro patch counts after the native-gradient backport) · **Target:** Adobe Acrobat Pro (Acrobat DC, continuous track 26.002.21931, macOS)

 Every known shortfall, one entry each, ranked by what it costs users. This is the work list: agents
 choose from the top unless the owner says otherwise, and prefer these over new P2/P3 checklist
@@ -68,6 +67,25 @@ update the numbers.

 ### 3. Editing existing text is fragile on real files

+- **Fork progress (2026-10-11):** compatible words and subset-font spaces form lines;
+  source fonts lacking a space glyph remain reusable; inline editing previews remove source
+  glyphs on a clone. Aligned visual rows now form mixed-style regions (including matrix-scaled headings),
+  with source-run styles preserved during editing and delete/save/reopen regressions. A private
+  real-file acceptance check and opt-in UI regression supplement synthetic coverage.
+  Embedded sfnt faces now render in the editor, including Mac format-6 subsets adapted in memory
+  through the PDF Unicode map. Source baselines remain stable; draft frames expand/shrink with
+  visible text, and `text_edit_layout` measures saved draft bounds without applying them.
+  Page/path-clipped artwork bounds and text-first hit testing prevent large cropped images from
+  blocking text. A separate private four-page regression opens all 73 detected text regions;
+  curve/hole hit testing now evaluates clipping paths and fill rules. A clip the image owns
+  (`q re W n cm Do Q`) moves with it; shared path clips stay where they are.
+  Full matching document fonts complete absent subset glyphs; explicit installed/file font
+  selection, TrueType/OpenType-CFF embedding, disjoint style ranges, marked paragraph boundaries
+  and single-face OpenType shaping/bidi have regression coverage. Actual Chinese keyboard
+  insertion/deletion and save/reopen renders are checked on all four private pages.
+  Legacy non-SFNT previews, mixed-font/style contextual runs, structure-tree fidelity and reliable
+  semantic grouping on every untagged PDF remain open. Estimates are unchanged.
+
 - **Missing:** robust in-place editing of text PdfCraft didn't write: subset fonts without the
  needed glyphs, CJK and right-to-left text, rotated text, lists, superscript/subscript, keeping
  structure tags, find and replace in edit mode; vector and object editing; arrange and align.
@@ -287,6 +305,7 @@ update the numbers.

 | Date | Change | Summary |
 |---|---|---|
+| 2026-10-11 | minor | Contributor fork: mixed-style visual regions, source-font space reuse and a read-only textless background. Embedded sfnt source faces and Mac subset Unicode mappings keep edit baselines stable; live frames follow Apply/Save geometry as text grows or shrinks. Engine/tool/UI regressions and private all-page checks cover the changes; full matching font import, CFF, range styles, shaping and private Chinese typing checks added; legacy programs and general fidelity remain open; estimates unchanged |
 | 2026-10-11 | patch | Gap 2: 23 hayro-interpret and 10 hayro patches after axial and radial shadings became native gradients (backport of hayro 0.8) |
 | 2026-10-11 | minor | Closed gap 1 (#774, fixed by #836; numbers kept, its interop suite moved to gap 12); gap 6 lists the fixed #799–#821 batch; gap 3 and 16 updated for #844 (same-page move), #740 (column select) and #759 (1:1 touchpad scrolling) |
 | 2026-10-10 | minor | Removed the alpha markers: with the cross-app gate rule, gaps 1 and 8 are partial sub-cases, not blockers; stage alpha |
@@ -83,7 +83,7 @@ total matches the parity estimate.
 | M4 | Engine, history, save, organize | 100–180 | 95% | 8–15 | Done:<br>- command registry (menus, shortcuts and palette all use it);<br>- undo/redo; incremental, atomic and encrypted saves;<br>- autosave and crash recovery;<br>- organize, combine, extract, split and insert-from-file, with identical fonts and images stored once;<br>- CLI `edit/combine/extract/split`.<br>Done since: Combine files in its own tab (sortable, resizable columns; folders; early warnings; unlocking protected files), bookmark editing, page labels (Number pages), CLI `run`, Set Page Boxes, Crop tool, Duplicate pages, Ctrl+A / Cmd+A to select all pages in Organize, Replace pages, bookmarks from tagged headings. Missing: page transitions, recovery on the web |
 | M5 | Comments (all annotation types, XFDF) | 120–200 | 88% | 12–25 | Done: notes, highlight/underline/strikeout/squiggly, text boxes, ink, lines, arrows, rectangles, ovals, stamps (dynamic, Sign Here, Standard Business), with appearance streams; replies, status, checkmarks, locking, move/resize/restyle/delete; properties dialog; panel filter and sort; hide all; summaries (comments only); XFDF/FDF import and export (partial imports preserve existing reply and review-status links); flatten; Fill & Sign; agent tools.<br>Done since: polygons, connected lines, clouds, callouts, inserted text, colour and checkmark filters; image signature pointer previews, selection handles and live image movement/resizing with proportional corners and independent edge handles. Missing: custom stamps, replace-text proposals, summary layouts with the page |
 | M6 | Forms + JavaScript | 160–320 | 50% | 40–75 | Done: filling all field types with regenerated appearances; Prepare a form (every field type, multi-select/shared properties, move/resize/delete, Field Properties General/Appearance/Position/Options/Format/Validate/Calculate); Acrobat's AF format/keystroke/validate/calculate functions and simplified field notation run natively in Acrobat's event order; tab order; push-button actions; flatten; agent tools. Form data exchange (FDF, XFDF, XML, CSV, text) done.<br>Done since: JavaScript engine (boa, sandboxed) running custom keystroke/validate/calculate/format and button scripts, document JavaScripts, console. Missing: Actions tab, wider object model (annotations, layers, dialogs), XFA |
-| M7 | Content editing (text, images, header/footer, watermark) | 250–500 | 20% | 100–180 | Done: header & footer, watermarks, backgrounds, Bates; added text and images that stay editable (move, resize, format, rotate, flip, crop, replace); links (Link tool, Link Properties, create from URLs, remove all). Done since: #594 ordinary paragraph drags preserve overlapping source text; UI/engine regressions, native save/reopen, independent-reader checks and full CI passed in the Linux test environment. Missing: editing existing text and images in place (the longest pole), image/PDF watermarks |
+| M7 | Content editing (text, images, header/footer, watermark) | 250–500 | 20% | 100–180 | Done: header & footer, watermarks, backgrounds, Bates; added text and images that stay editable (move, resize, format, rotate, flip, crop, replace); links (Link tool, Link Properties, create from URLs, remove all). Done since (#1116): editable text regions grouped across compatible words and subset fonts, one rich-text editor over a background with the source text removed, embedded sfnt faces reused as editor faces, and visible (clipped) bounds for cropped-image selection and resize.<br>Done since: #594 ordinary paragraph drags preserve overlapping source text; UI/engine regressions, native save/reopen, independent-reader checks and full CI passed in the Linux test environment. Missing: editing existing text and images in place (the longest pole), image/PDF watermarks |
 | M7 | Content editing (text, images, header/footer, watermark) | 250–500 | 20% | 100–180 | Done: header & footer, watermarks, backgrounds, Bates; added text and images that stay editable (move, resize, format, rotate, flip, crop, replace); links (Link tool, Link Properties, create from URLs, remove all). Missing: editing existing text and images in place (the longest pole), watermark print/screen visibility and repeat |
 | M6 | Forms + JavaScript | 160–320 | 50% | 40–75 | Done: filling all field types with regenerated appearances; Prepare a form (every field type, multi-select/shared properties, move/resize/delete, Field Properties General/Appearance/Position/Options/Format/Validate/Calculate); Acrobat's AF format/keystroke/validate/calculate functions and simplified field notation run natively in Acrobat's event order; tab order; push-button actions; flatten; agent tools. Form data exchange (FDF, XFDF, XML, CSV, text) done.<br>Done since: JavaScript engine (boa, sandboxed) running custom keystroke/validate/calculate/format and button scripts, document JavaScripts, console. Missing: Actions tab, wider object model (annotations, layers, dialogs), XFA<br>Done since: Existing simple field-font encodings and Differences are respected when generating appearances; an unencodable value uses a separate Helvetica appearance font without changing the source font. Synthetic reopen regressions cover punctuation, subset fallback and multiline text. Exact font metrics/layout and broader Unicode fallback remain incomplete. |
 | M6 | Forms + JavaScript | 160–320 | 50% | 40–75 | Done: filling all field types with regenerated appearances; Prepare a form (every field type, multi-select/shared properties, move/resize/delete, Field Properties General/Appearance/Position/Options/Format/Validate/Calculate); Acrobat's AF format/keystroke/validate/calculate functions and simplified field notation run natively in Acrobat's event order; tab order; push-button actions; flatten; agent tools. Form data exchange (FDF, XFDF, XML, CSV, text) done.<br>Done since: JavaScript engine (boa, sandboxed) running custom keystroke/validate/calculate/format and button scripts, document JavaScripts, console. Missing: Actions tab, wider object model (annotations, layers, dialogs), XFA<br>Done since: Tab and Shift-Tab wrapping to the same field or another widget of that field refresh the newly opened editor from the accepted value before Save. Synthetic UI regressions cover both directions, same-frame Save, validation refusal and undo/redo. |
@@ -144,6 +144,8 @@ M2 (renderer), M7 (content editing), M10 (OCR and Office), M11 (Preflight and st
 | 2026-10-11 | minor | M13/#971: cap materialized text-search matches to the requested limit plus one continuation match. |
 | 2026-10-11 | minor | M7: #594 ordinary paragraph drags validated in the Linux test environment with source-loss baseline failures, UI/engine regressions, native save/reopen and all eight CI gates. Estimates unchanged. |
 | 2026-10-11 | minor | M4: direct Organize overview, checkbox selection and individual page actions. Estimates unchanged. |
+| 2026-10-11 | minor | Contributor fork: document-font selection and subset completion, CFF, style ranges, contextual/bidi save/reopen and all-page Chinese keyboard acceptance; curve/hole hit testing (shared clips stay fixed, as on main). Scope remains bounded; percentages unchanged |
+| 2026-10-11 | minor | Contributor fork: compatible word/subset-space grouping, source-font space reuse and a read-only textless editor background. Mixed-style regions now covered by engine/tool/UI regressions and private real-file checks; embedded sfnt faces, stable baselines and live draft extents now covered; installed-font selection and unsupported source programs remain open; estimates unchanged |
 | 2026-10-11 | minor | Synced with closed issues: encrypted output opens in Acrobat (#774, #836), so gap 1 left rank 0 and convert and share (32–55 h, the gap's 8–15 h removed); organize, XFDF and multi-object move fixes (#817, #821, #809, #819, #844); the #816 panic and the #799–#821 batch fixed; rank 1 names web printing (Windows shipped, #756). Stage and readiness numbers not re-measured |
 | 2026-10-11 | minor | M6: respect existing form-font encodings; retain source fonts on appearance fallback. Estimates unchanged. |
 | 2026-10-11 | minor | M5: partial XFDF/FDF imports preserve existing replies and review statuses through save and export. Estimates unchanged. |
@@ -1,6 +1,6 @@
 # PdfCraft parity with Adobe Acrobat Pro

-> **Last reviewed:** 2026-10-10 · **Last updated:** 2026-10-11 · **Change:** minor (closed issues synced, scores not re-judged: #774, #756, #740, #759, #799–#821, #825, #844; earlier: readiness table with hours per audience; full number restated as the standard's additive weighted sum, 47% → 49%; earlier: second look: cross-cutting double count removed, mainstream-practitioner number added, core-workflow gate applied → alpha) · **Target:** Adobe Acrobat Pro (Acrobat DC, continuous track 26.002.21931, macOS)
+> **Last reviewed:** 2026-10-10 · **Last updated:** 2026-10-11 · **Change:** minor (document-font subset completion, source styles and curved/shared image clips in the contributor fork; closed issues synced, scores not re-judged: #774, #756, #740, #759, #799–#821, #825, #844; earlier: readiness table with hours per audience; full number restated as the standard's additive weighted sum, 47% → 49%; earlier: second look: cross-cutting double count removed, mainstream-practitioner number added, core-workflow gate applied → alpha) · **Target:** Adobe Acrobat Pro (Acrobat DC, continuous track 26.002.21931, macOS)

 The authoritative assessment of how close PdfCraft is to Acrobat Pro. [ROADMAP.md](../ROADMAP.md)
 summarizes it; [gaps.md](gaps.md) lists every shortfall one by one; the deep-dive checklists are
@@ -292,6 +292,7 @@ licensed OCR or AI model.

 | Date | Change | Summary |
 |---|---|---|
+| 2026-10-11 | minor | Contributor fork: document-font selection and subset completion, CFF, style ranges, contextual/bidi save/reopen and all-page Chinese keyboard acceptance; curve/hole hit testing (shared clips stay fixed, as on main). Scope remains bounded; percentages unchanged |
 | 2026-10-11 | minor | Synced with closed issues: encrypted output opens in Acrobat (#774, #836), Windows prints (#756, #847), column select (#740), 1:1 touchpad scrolling (#759), same-page multi-object move (#844), #825 and the #799–#821 fix batch. Text only: scores, readiness and hours not re-judged |
 | 2026-10-10 | minor | Readiness table: hours to ≈ 95% per audience (full 780–1,400, mainstream 500–900, essentials 180–330). Full number restated as the standard's additive weighted sum over dimensions with written weights: 47% → 49%. Method aligned with the standard, no new evidence |
 | 2026-10-10 | minor | Added the essentials-user score (≈ 66%): weighted depth of 13 everyday features, discounted for launch, discoverability and opening others' files |