From 1ca576309e68910be80d20a1e6b00840c5ee4c84 Mon Sep 17 00:00:00 2001 From: Brandon Thomas Date: Sun, 4 Oct 2026 15:25:14 -0400 Subject: [PATCH] Git: no line-ending conversion for any file, so Windows checkouts keep asset hashes Windows runners check out with core.autocrlf=true, which turned the SVG icons' LF into CRLF, so their SHA-256 no longer matched ATTRIBUTION.toml and xtask's the_real_manifest_passes failed there (hidden until now behind the perf-test failure, since cargo test stops at the first failing binary). Co-Authored-By: Claude Opus 5.5 --- .gitattributes | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/.gitattributes b/.gitattributes index 4a67e8e06..5db32cda2 100644 --- a/.gitattributes +++ b/.gitattributes @@ -1,9 +1,15 @@ -# Byte-exact fixtures and assets: never convert line endings (Windows checkouts use -# core.autocrlf=true, which changes the signed bytes of a PDF and breaks its signature). +# Every checkout is byte-identical to the repository: no line-ending conversion, ever. +# Windows checkouts default to core.autocrlf=true, which rewrote signed PDFs (breaking their +# signatures) and assets whose SHA-256 ATTRIBUTION.toml records (cargo xtask assets). +* -text + +# Not text at all: no textual diffs or merges either. *.pdf binary *.p12 binary -*.pem -text *.pfb binary *.ttf binary *.icc binary +*.icns binary +*.ico binary *.png binary +*.brotli binary