lightcraft/.github/workflows/packaging-lint.yml

# Quick checks for the release pipeline (no Rust build): workflow syntax, packaging
# shell/PowerShell scripts, and the Linux desktop/AppStream/Flatpak metadata (seconds), plus a
# Windows job that builds and installs throwaway per-user MSI probes for the install-folder
# searches (a few minutes).
name: Packaging lint

on:
  push:
    branches: [main, release]
    paths: [".github/workflows/**", "packaging/**", "assets/app-icon/**"]
  pull_request:
    paths: [".github/workflows/**", "packaging/**", "assets/app-icon/**"]
  workflow_dispatch:

permissions:
  contents: read

concurrency:
  group: packaging-lint-${{ github.ref }}
  cancel-in-progress: true

jobs:
  lint:
    runs-on: ubuntu-latest
    env:
      ACTIONLINT_VERSION: 1.7.12
    steps:
      - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
      - name: Install tools
        run: |
          sudo apt-get update
          sudo apt-get install -y --no-install-recommends shellcheck desktop-file-utils appstream libxml2-utils python3-yaml
          curl -fsSL "https://github.com/rhysd/actionlint/releases/download/v${ACTIONLINT_VERSION}/actionlint_${ACTIONLINT_VERSION}_linux_amd64.tar.gz" \
            | tar -xz -C "$RUNNER_TEMP" actionlint
      - name: actionlint
        run: |
          "$RUNNER_TEMP/actionlint" -color
      - name: shellcheck
        run: shellcheck packaging/*.sh packaging/*/*.sh
      - name: PowerShell
        shell: pwsh
        run: |
          foreach ($f in Get-ChildItem packaging/windows/*.ps1) {
            $errors = $null
            [System.Management.Automation.Language.Parser]::ParseFile($f.FullName, [ref]$null, [ref]$errors) | Out-Null
            if ($errors) { $errors | ForEach-Object { Write-Output "::error file=$($f.Name)::$_" }; exit 1 }
            Write-Output "ok $($f.Name)"
          }
      - name: XML, desktop entry, AppStream, Flatpak manifest
        run: |
          xmllint --noout packaging/windows/lightcraft.wxs packaging/macos/*.plist* packaging/linux/*.xml*
          # Windows Installer needs Icon ids ending in .ico or .exe, or shortcuts show a blank icon.
          if grep -oE '<Icon Id="[^"]*"' packaging/windows/lightcraft.wxs | grep -vE '\.(ico|exe)"$'; then
            echo "::error::Icon Id must end in .ico or .exe"; exit 1
          fi
          # The interactive installer asks where to install and ends on a completion page (issues #18, #399).
          for want in '<UIRef Id="LightcraftUI" />' 'Value="InstallDirDlg"' '<Property Id="WIXUI_INSTALLDIR" Value="INSTALLFOLDER" />' \
              'Key="Software\LightCraft" Name="InstallFolder"' 'Value="LaunchLightcraft"'; do
            grep -qF "$want" packaging/windows/lightcraft.wxs || { echo "::error::lightcraft.wxs lost: $want"; exit 1; }
          done
          # The completion page the Publish events point at must actually exist: a Publish alone
          # does not pull the dialog fragment into the MSI, and without the DialogRef the
          # installer finishes silently (issues #790, #892).
          grep -qF '<DialogRef Id="ExitDialog" />' packaging/windows/lightcraft.wxs \
            || { echo "::error::ExitDialog is not referenced; installs and removes end without a completion dialog"; exit 1; }
          desktop-file-validate packaging/linux/ai.storyteller.lightcraft.desktop
          sed -e 's/@VERSION@/0.0.0/' -e 's/@DATE@/2026-01-01/' packaging/linux/ai.storyteller.lightcraft.metainfo.xml.in >"$RUNNER_TEMP/ai.storyteller.lightcraft.metainfo.xml"
          appstreamcli validate --no-net --explain "$RUNNER_TEMP/ai.storyteller.lightcraft.metainfo.xml"
          python3 - <<'EOF'
          import yaml
          src = yaml.safe_load(open("packaging/linux/flatpak/ai.storyteller.lightcraft.yml"))
          bundle = yaml.safe_load(open("packaging/linux/flatpak/ai.storyteller.lightcraft.bundle.yml"))
          for m in (src, bundle):
              assert m["id"] == "ai.storyteller.lightcraft" and m["command"] == "lightcraft", m["id"]
          for key in ("runtime", "runtime-version", "sdk", "finish-args"):
              assert src[key] == bundle[key], f"Flatpak manifests disagree on {key}: {src[key]} vs {bundle[key]}"
          print("Flatpak manifests ok")
          EOF
      - name: FreeBSD tarball layout (stub binaries)
        run: bash packaging/freebsd/package.sh --dry-run

  windows-install-folder:
    runs-on: windows-latest
    timeout-minutes: 10
    steps:
      - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
      - name: Install WiX
        shell: pwsh
        run: dotnet tool install --global wix --version 5.0.2
      - name: Install-folder fallback and precedence (real MSI AppSearch)
        shell: pwsh
        run: |
          ./packaging/windows/test-install-folder.ps1 -Arch x64
          ./packaging/windows/test-install-folder.ps1 -Arch x86