From d1e6aa2e85a15c59b6d362f456734e0030fbfb17 Mon Sep 17 00:00:00 2001 From: Brandon Thomas Date: Mon, 12 Oct 2026 04:28:59 -0400 Subject: [PATCH] clippy: needless borrows at the context_menu calls Co-Authored-By: Claude Opus 5.5 --- crates/ui-egui/src/panels/project.rs | 2 +- crates/ui-egui/src/panels/timeline.rs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/ui-egui/src/panels/project.rs b/crates/ui-egui/src/panels/project.rs index d7f6e9a3..e18f76bc 100644 --- a/crates/ui-egui/src/panels/project.rs +++ b/crates/ui-egui/src/panels/project.rs @@ -1014,7 +1014,7 @@ fn label_index(l: Label) -> usize { /// The column header's context menu: show or hide the optional columns. fn column_menu(app: &mut EffectcraftApp, resp: &egui::Response) { - crate::widgets::context_menu(&resp, |ui| { + crate::widgets::context_menu(resp, |ui| { ui.label(egui::RichText::new(crate::i18n::tr("Columns")).weak()); for (key, label, _) in COLUMNS { let mut on = app.ui.project_columns.iter().any(|c| c == key); diff --git a/crates/ui-egui/src/panels/timeline.rs b/crates/ui-egui/src/panels/timeline.rs index 8962204f..186ebef7 100644 --- a/crates/ui-egui/src/panels/timeline.rs +++ b/crates/ui-egui/src/panels/timeline.rs @@ -2684,7 +2684,7 @@ pub fn show(app: &mut EffectcraftApp, ui: &mut egui::Ui, rect: Rect) { app.auto.add("timeline.empty", empty_rect, "Right-click to create a layer"); } for (response, area) in [(&outline_empty, "outline"), (&empty, "graph")] { - crate::widgets::context_menu(&response, |ui| { + crate::widgets::context_menu(response, |ui| { let menu = ui.menu_button(crate::i18n::tr("New"), |ui| { for (key, label, command, params) in [ ("text", "Text", "layer.newText", json!({})), @@ -3511,7 +3511,7 @@ fn layer_context_menu(resp: &egui::Response, comp: &Comp, layer: &Layer, selecte actions.push(("layer.select".into(), json!({"layers": [layer.id.0]}))); } let targets: Vec = if in_selection { comp.layers.iter().filter(|l| selected.contains(&l.id)).map(|l| l.id.0).collect() } else { vec![layer.id.0] }; - crate::widgets::context_menu(&resp, |ui| layer_menu(ui, &targets, vector, actions)); + crate::widgets::context_menu(resp, |ui| layer_menu(ui, &targets, vector, actions)); } /// Shared layer actions for Timeline rows and Composition context menus.